fix: validate date-time-picker when required is set to false (#7908) (#…

…7913) Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
vaadin · Oct 2, 2024 · 9315368 · 9315368
1 parent e44d5d7
commit 9315368
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/packages/date-time-picker/src/vaadin-date-time-picker.js b/packages/date-time-picker/src/vaadin-date-time-picker.js
@@ -724,6 +724,12 @@ class DateTimePicker extends FieldMixin(DisabledMixin(FocusMixin(ThemableMixin(E
     if (timePicker) {
       timePicker.required = required;
     }
+
+    if (this.__oldRequired && !required) {
+      this.validate();
+    }
+
+    this.__oldRequired = required;
   }
 
   /** @private */

diff --git a/packages/date-time-picker/test/validation.test.js b/packages/date-time-picker/test/validation.test.js
@@ -200,6 +200,11 @@ const fixtures = {
         dateTimePicker.validate();
         expect(dateTimePicker.invalid).to.be.true;
       });
+
+      it('should validate when setting required to false', () => {
+        dateTimePicker.required = false;
+        expect(validateSpy).to.be.calledOnce;
+      });
     });
 
     describe('document losing focus', () => {