Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider updating to Quill 2.0 once stable is released #1680

Open
web-padawan opened this issue May 17, 2019 · 3 comments
Open

Consider updating to Quill 2.0 once stable is released #1680

web-padawan opened this issue May 17, 2019 · 3 comments
Labels

Comments

@web-padawan
Copy link
Member

Quickly updated RTE on top of Quill 2.0.0-dev.3 for possible using in Incubator project.

Prototype branch: https://github.com/vaadin/vaadin-rich-text-editor/tree/quill-2x
Quill fork: https://github.com/web-padawan/quill/tree/shadow-2x

There are at least 2 breaking changes in Quill 2.0 affecting us:

  • <div class="ql-code-editor-container"> is now used for code blocks instead of <pre>
  • <ol> is now used for all lists, and type is set via <li data-list="bullet>">

Also, few keyboard navigation tests failed (didn't spend any time to investigate).

Once 2.0 is released as a stable we should keep this in mind if we want to update.

@vaadin-bot vaadin-bot transferred this issue from vaadin/vaadin-rich-text-editor May 19, 2021
@web-padawan
Copy link
Member Author

Regarding <ol> tag used for list - here's a comment suggesting quill.getSemanticHTML() which returns correct markup.

@web-padawan
Copy link
Member Author

One issue which might be fixed by upgrading to Quill 2: vaadin/flow-components#4773

@web-padawan
Copy link
Member Author

Some commits in v2.0 with improvements that we could benefit from:

We could also investigate supporting nested lists feature as quill.getSemanticHTML() correctly returns markup also for nested lists as described in the issue: slab/quill#979 (comment). Note that indentation outside lists (i.e. in regular paragraphs) would still need to be handled by replacing ql-indent classes, see slab/quill#4156

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants