Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[rich-text-editor] When applying spellcheck suggestion, the text disappears #6369

Closed
web-padawan opened this issue Aug 17, 2023 · 4 comments · Fixed by #6507
Closed

[rich-text-editor] When applying spellcheck suggestion, the text disappears #6369

web-padawan opened this issue Aug 17, 2023 · 4 comments · Fixed by #6507

Comments

@web-padawan
Copy link
Member

web-padawan commented Aug 17, 2023

Description

From a customer:

When accepting the browsers suggested word - then the complete paragraph disappears.
This does not happen if I type in the text, only if I paste in the text (normal paste)
If I do a text-only-paste, the spell check functionality is ok.

Note

This issue only happens on Windows (Chrome, Edge)

rte-wtf.mp4

Expected outcome

The text should not disappear.

Minimal reproducible example

Can be reproduced with dev/rich-text-editor.html page in this repo.

Steps to reproduce

  1. Copy/paste some text found in a browser.
  2. Trigger the spell check on word (not the first word).
  3. Apply any of the suggestions.
  4. Now the text is gone.

Environment

Vaadin version(s): 24.2 (latest)
OS: Windows

Browsers

Chrome, Edge

@web-padawan
Copy link
Member Author

UPD: tested this more and now I can reproduce it also on the Quill website, so it is a Quill bug after all.

rte-quill.mp4

@web-padawan
Copy link
Member Author

web-padawan commented Aug 24, 2023

Here are relevant Quill issues: slab/quill#2527, slab/quill#2096. It is mentioned that they have been fixed by slab/quill#3807 which is merged to develop branch for the upcoming 2.0 release (not yet published).

We should investigate whether we can update our fork (with shadow DOM support) to include the fix linked above.

@LcsGa
Copy link

LcsGa commented Nov 13, 2023

@web-padawan Hi! When the 2.0 version will be published? I have the same issue

@web-padawan
Copy link
Member Author

Hi, 2.0 is the Quill version I referred to. The workaround that I applied will be released in Vaadin 24.2.3 this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants