Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grid with MultiSelect Mode: space key on selection cell doesn't work #7146

Closed
AndreasSamjeske opened this issue Feb 23, 2024 · 1 comment · Fixed by #7178
Closed

Grid with MultiSelect Mode: space key on selection cell doesn't work #7146

AndreasSamjeske opened this issue Feb 23, 2024 · 1 comment · Fixed by #7178
Assignees

Comments

@AndreasSamjeske
Copy link

AndreasSamjeske commented Feb 23, 2024

Description

When a cell with a checkbox is focused, it should be toggleable by hitting SPACE. In fact, that works in Vaadin 23.
In Vaadin 24 you have to hit ENTER first. Then you are in interaction mode (I hope, this is the right term). Now the focus is directly on the checkbox and hitting SPACE works. But I don't wanna be forced to enter this mode.

Expected outcome

SPACE toggles the checkbox in grid cells in Vaadin 24, too.

Minimal reproducible example

Vaadin Examples will do:

image

Steps to reproduce

  1. Hitting TAB until some cell of grids content area has focus.
  2. Navigating to a cell with a checkbox using arrow keys.
  3. Pressing SPACE.

Environment

Vaadin version(s): 24
OS: Windows 11

Browsers

Edge

@web-padawan
Copy link
Member

web-padawan commented Feb 29, 2024

The issue is caused by the selection column change described in vaadin/flow-components#5833 (comment):

In Vaadin 24.1 the selection checkbox had a click event listener, that performed the selection and sent it over to the server.
In the latest Vaadin this is now changed, and the checkbox performs the actual selection on the checked-changed event.

The actual change was vaadin/flow-components#5246 and it landed in Vaadin 24.2 (so 24.2 and 24.3 are also affected).

We will discuss this issue with the team. Probably the click listener logic could be restored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants