Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: toggle checkbox on selection column cell Space key #7178

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #7146

This PR changes the behavior of vaadin-grid-selection-column (and will also apply to its Flow version) like this:

  • Pressing Space on the selection column cell toggles the checkbox regardless of autoSelect property,
  • In interaction mode, Space is handled as previously (added logic to prevent toggling checked twice).

Type of change

  • Behavior altering fix

Co-authored-by: Sergey Vinogradov <mr.vursen@gmail.com>
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan removed the request for review from tomivirkki March 12, 2024 09:19
@web-padawan web-padawan merged commit afb3820 into main Mar 12, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/space-key-select branch March 12, 2024 09:22
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.2, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick afb3820
error: could not apply afb3820... fix: toggle checkbox on selection column cell Space key (#7178)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha15 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid with MultiSelect Mode: space key on selection cell doesn't work
3 participants