Skip to content

feat: add overflow-indicator-top and oveflow-indicator-bottom variants #10182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
web-padawan merged 4 commits into from
Sep 16, 2025
Merged

feat: add overflow-indicator-top and oveflow-indicator-bottom variants #10182

web-padawan merged 4 commits into from
Sep 16, 2025

Conversation

@jouni
Copy link
Member

@jouni jouni commented Sep 16, 2025 •
edited
Loading

Allow developers to choose if they want to show the indicator at the top, bottom, or both edges of Scroller and Virtual List.

jouni
jouni commented Sep 16, 2025
View reviewed changes
...scroller/test/visual/base/screenshots/scroller/baseline/theme-overflow-indicators-bottom.png
Copy link
Member Author

@jouni jouni Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure why the previous visual test references screenshots didn't show the scrollbars. The one where both indicators are shown still doesn't show the scrollbars 🤷‍♂️

Copy link
Member

@web-padawan web-padawan Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have hide-scrollbars.js file but IMO it can be removed. I'll handle that.

Copy link
Member

@web-padawan web-padawan Sep 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

UPD: removed that file from base styles but preserved for Lumo since it is tested with older Chrome version where scrollbars make the appearance of the indicators less obvious (I believe that’s the reason why they were hidden).

@jouni jouni requested a review from web-padawan September 16, 2025 08:27
@web-padawan web-padawan force-pushed the feat/scroller-overflow-indicators branch from ee4ef2f to b2b2461 Compare September 16, 2025 09:03
@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@web-padawan web-padawan merged commit bbc612e into main Sep 16, 2025
9 checks passed
@web-padawan web-padawan deleted the feat/scroller-overflow-indicators branch September 16, 2025 09:51
@vaadin-bot
Copy link
Collaborator

vaadin-bot commented Oct 2, 2025

This ticket/PR has been released with Vaadin 25.0.0-alpha12.

@web-padawan web-padawan mentioned this pull request Jan 7, 2026
Merged
@vaadin-bot vaadin-bot mentioned this pull request Jan 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@web-padawan web-padawan web-padawan approved these changes

Assignees

No one assigned

Labels

Released with Vaadin 25.0.0-alpha12

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jouni @vaadin-bot @web-padawan