refactor: split padding-container custom CSS property in base styles #10447
+73
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 tasks
jouni
reviewed
Nov 12, 2025
Member
jouni
left a comment
jouni
left a comment
There was a problem hiding this comment.
I’d like to rename these to --vaadin-padding-block-container and --vaadin-padding-inline-container. Always hard to decide how to order the parts (is it "padding, container, block", "padding-block, container", "container, padding-block").
web-padawan
force-pushed
the
refactor/split-padding-container
branch
from
d4a9ea0 to
1698aba
Compare
web-padawan
force-pushed
the
refactor/split-padding-container
branch
from
1698aba to
e685076
Compare
web-padawan
force-pushed
the
refactor/split-padding-container
branch
from
38acc13 to
0188cb5
Compare
|
jouni
approved these changes
Nov 13, 2025
ugur-vaadin
pushed a commit
that referenced
this pull request
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of #10417
Type of change