fix: make virtualizer react to asynchronous item size increase #3907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
tomivirkki
changed the title
web-padawan
approved these changes
May 20, 2022
|
This ticket/PR has been released with Vaadin 23.1.0.rc1 and is also targeting the upcoming stable 23.1.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of vaadin/flow-components#3206
If a virtualizer child element has a height of 0 after an update, currently the Virtualizer would set
min-height: 200pxfor it to avoidiron-list-corefrom generating an unlimited amount of elements while trying to cover the viewport.The problem with
min-heightis that once the element content gets changed asynchronously (in the case of<flow-component-renderer>when the content component gets loaded and appended), the effective height of the element would not change (it would still remain 200 pixels high) and internal resizing logic would not invoke.This PR changes the Virtualizer to use
padding-topinstead ofmin-heightfor the placeholder size so that once the content updates, the element's effective height will actually change, which in turn invokes the internalResizeObserver.NOTE: The initial revision of this PR used
padding-bottom, but an inline padding-bottom style is already used by<vaadin-grid>'s row details -feature so it's not an option.