fix: sync the hasInputValue state on input #4335
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It turns out that
TimePicker
prevents thechange
event on the input element until it loses focus, so it is possible to commit a non-empty value on Enter but have thehasInputValue
state not updated.This PR makes the
hasInputValue
state update oninput
rather thanchange
which ensureshasInputValue
is synced in the above case as well.A follow-up to #4276
Related to vaadin/flow-components#3515
Type of change
Checklist