Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure focused date is visible if overlay is small (CP: 24) #4759

Merged
merged 4 commits into from
Oct 17, 2022

Conversation

sissbruecker
Copy link
Contributor

Copy link
Member

@web-padawan web-padawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Integration tests started to fail for some reason:

integration/tests/dialog-date-picker.test.js:

 ❌ date-picker in dialog > modal > should focus the Today button on second Tab when inside a dialog
      AssertionError: expected false to be true
      + expected - actual

      -false
      +true

      at o.<anonymous> (integration/tests/dialog-date-picker.test.js:45:87)

 ❌ date-picker in dialog > modal > should focus the input on calendar date Shift Tab when inside a dialog
      AssertionError: expected false to be true
      + expected - actual

      -false
      +true

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sissbruecker
Copy link
Contributor Author

sissbruecker commented Oct 17, 2022

Integration tests started to fail for some reason:

Fixed by waiting for the scroll animation to finish. It seems for the integration tests the new week-based scrolling kicks in, which always triggers a scroll on focus, even if the date is already visible - for month-based scrolling we only scroll if the respective month is not already visible, so there was no need to wait.

@vaadin-bot
Copy link
Collaborator

Hi @sissbruecker , this commit cannot be picked to 23.1 by this bot, can you take a look and pick it manually?
Error Message: Error: Command failed: git cherry-pick 9829407
error: could not apply 9829407... fix: ensure focused date is visible if overlay is small (#4759)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan pushed a commit that referenced this pull request Oct 17, 2022
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
web-padawan pushed a commit that referenced this pull request Oct 17, 2022
Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
sissbruecker added a commit that referenced this pull request Oct 17, 2022
sissbruecker added a commit that referenced this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants