-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure focused date is visible if overlay is small (CP: 24) #4759
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Integration tests started to fail for some reason:
integration/tests/dialog-date-picker.test.js:
❌ date-picker in dialog > modal > should focus the Today button on second Tab when inside a dialog
AssertionError: expected false to be true
+ expected - actual
-false
+true
at o.<anonymous> (integration/tests/dialog-date-picker.test.js:45:87)
❌ date-picker in dialog > modal > should focus the input on calendar date Shift Tab when inside a dialog
AssertionError: expected false to be true
+ expected - actual
-false
+true
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Fixed by waiting for the scroll animation to finish. It seems for the integration tests the new week-based scrolling kicks in, which always triggers a scroll on focus, even if the date is already visible - for month-based scrolling we only scroll if the respective month is not already visible, so there was no need to wait. |
Hi @sissbruecker , this commit cannot be picked to 23.1 by this bot, can you take a look and pick it manually? |
…23.1) (cherry picked from commit 9829407)
Cherry-pick of vaadin/vaadin-date-picker#809