feat: add auto-expand properties instead of allChipsVisible #6775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Nov 10, 2023
packages/multi-select-combo-box/src/vaadin-multi-select-combo-box.js
Outdated
Show resolved
Hide resolved
tomivirkki
reviewed
Nov 10, 2023
packages/multi-select-combo-box/src/vaadin-multi-select-combo-box.js
Outdated
Show resolved
Hide resolved
web-padawan
force-pushed
the
refactor/mscb-auto-expand
branch
4 times, most recently
from
cb41677 to
0971a8d
Compare
web-padawan
force-pushed
the
refactor/mscb-auto-expand
branch
from
0971a8d to
863b97c
Compare
tomivirkki
approved these changes
Nov 10, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
web-padawan
added a commit
that referenced
this pull request
Nov 15, 2023
web-padawan
added a commit
that referenced
this pull request
Nov 15, 2023
web-padawan
added a commit
that referenced
this pull request
Nov 16, 2023
|
This ticket/PR has been released with Vaadin 24.3.0. |
|
This ticket/PR has been released with Vaadin 23.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6722
Removed
allChipsVisibleproperty in favor of two new properties as described in #6722 (comment):autoExpandHorizontallysets width on the container toauto(could be alsofit-content),autoExpandVerticallymakes chips wrap and setsdisplay: contentson thechipspart.With
autoExpandHorizontally: truewe still have an overflow chip shown when reaching max width.There is a new logic added to detect if the component has enough space to increase its width.
Type of change