fix!: exclude hidden columns from sorting (24.4) #6927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vursen
force-pushed
the
fix/grid/exclude-hidden-sort-columns-from-sorting
branch
from
4f12326
to
7a52b83
Compare
vursen
force-pushed
the
fix/grid/exclude-hidden-sort-columns-from-sorting
branch
from
7a52b83
to
3af7c4b
Compare
Merged
1 task
vursen
commented
Dec 8, 2023
| assertColumnCellOrder(columns[1], ['1', '2', '3']); | ||
| }); | ||
|
|
||
| it('should update sort order when column removed and grid is not attached', () => { |
There was a problem hiding this comment.
note: The sorters' order property becomes null for the time the grid is disconnected. It's a limitation of the new implementation which doesn't distinguish whether the column is hidden or the entire grid is hidden. I've assumed that it's not a big deal considering that the order property is restored to its original value when the grid is re-connected.
vursen
changed the title
vursen
changed the title
vursen
changed the title
|
|
tomivirkki
approved these changes
Dec 11, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
vursen
changed the title
vursen
changed the title
|
This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR updates the grid sorting logic so that it excludes hidden columns from sorting and includes them when they are shown again.
Precedes:
Part of vaadin/flow-components#5513
Type of change