refactor!: update drawer-toggle to not extend button #7005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
refactor/drawer-toggle-button
branch
from
94a5396 to
55f9468
Compare
|
vursen
approved these changes
Dec 27, 2023
Collaborator
|
This ticket/PR has been released with Vaadin 24.4.0.alpha1 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Same as #7004 but for
vaadin-drawer-togglecomponent.Changed to use
ButtonMixinandbuttonStylesCSS literal instead of extendingButtonclass.This eliminates the need for having
<slot name="tooltip">which was there just to prevent throwing an error.Also, from now on custom CSS applied to
vaadin-buttonwon't accidentally affectvaadin-drawer-toggle.Type of change