feat: add keepFilter option (#7063) (CP: 23.4) #7085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick of #7063
|
sissbruecker
commented
Jan 15, 2024
| // Restore input to the filter value. Needed when items are | ||
| // navigated with keyboard, which overrides the input value | ||
| // with the item label. | ||
| this.inputElement.value = this.filter; |
There was a problem hiding this comment.
Replaced the single occurence of this._inputElementValue with this.inputElement.value.
| @@ -110,6 +118,14 @@ describe('selecting items', () => { | |||
| comboBox.clear(); | |||
| expect(comboBox.selectedItems).to.deep.equal([]); | |||
| }); | |||
|
|
|||
| it('should keep the filter and input value when committing an invalid option', async () => { | |||
There was a problem hiding this comment.
Added the test from #7072 and updated the test in the keep filter suite to also verify that the filter is not reset.
web-padawan
approved these changes
Jan 15, 2024
|
This ticket/PR has been released with Vaadin 23.4.0.alpha2 and is also targeting the upcoming stable 23.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #7063