fix: avoid clearing filter when pressing clear button on mobile #7091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables the clear button logic from `vaadin-combo-box-mixin`, which clears the filter input when pressing the clear button. Instead, only the MSCB clear button logic is executed, which only clears the selection. The bug actually only occurs on the first touch event, and not on subsequent ones. The root cause is that on the first clear, `selectedItem` is changed from `undefined` to `null`, which runs the respective change logic that also resets the input. Ideally `selectedItem` would be initialized with `null`, so the change would never happen. However, doing so results in a lot of test failures. I guess it would require additional changes to handle the initial Polymer change event then, but if someone has an idea feel free to make suggestions.
|
web-padawan
approved these changes
Jan 18, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
Disables the clear button logic from `vaadin-combo-box-mixin`, which clears the filter input when pressing the clear button. Instead, only the MSCB clear button logic is executed, which only clears the selection.
sissbruecker
added a commit
that referenced
this pull request
Jan 18, 2024
… (#7092) Disables the clear button logic from `vaadin-combo-box-mixin`, which clears the filter input when pressing the clear button. Instead, only the MSCB clear button logic is executed, which only clears the selection. Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disables the clear button logic from
vaadin-combo-box-mixin, which clears the filter input when pressing the clear button. Instead, only the MSCB clear button logic is executed, which only clears the selection.The bug actually only occurs on the first touch event, and not on subsequent ones. The root cause is that on the first clear,
selectedItemis changed fromundefinedtonull, which runs the respective change logic that also resets the input. IdeallyselectedItemwould be initialized withnull, so the change would never happen. However, doing so results in a lot of test failures. I guess it would require additional changes to handle the initial Polymer change event then, but if someone has an idea feel free to make suggestions.Fixes #7066