Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support reverse button collapsing order in menu-bar #7124

Merged
merged 5 commits into from
Feb 12, 2024
Merged

feat: support reverse button collapsing order in menu-bar #7124

merged 5 commits into from
Feb 12, 2024

Conversation

tomivirkki
Copy link
Member

Description

Support reverse button collapsing order in menu-bar

keep-items-order.mp4

Part of vaadin/platform#5018

Type of change

Feature

@tomivirkki tomivirkki marked this pull request as draft February 8, 2024 10:24
@tomivirkki tomivirkki marked this pull request as ready for review February 8, 2024 11:00
tomivirkki
tomivirkki commented Feb 8, 2024
View reviewed changes
packages/menu-bar/src/vaadin-menu-bar-mixin.js
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that the button border-radius values not correct with reverseCollapse. Will fix.

Screenshot 2024-02-08 at 13 32 59

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. Couldn't find a CSS-only fix for this so I needed to compute first-visible and last-visible attributes for the buttons.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be considered a breaking change? I mean, if someone is customizing the buttons based on the previous CSS selectors (*-of-type), how would it behave with the new selectors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When reverseCollapse is not used, the previous selectors should work as before.

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomivirkki tomivirkki merged commit 7770546 into main Feb 12, 2024
9 checks passed
@tomivirkki tomivirkki deleted the feat/menu-bar/reverse-collapse branch February 12, 2024 07:06
@tomivirkki tomivirkki mentioned this pull request Feb 12, 2024
Merged
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha4 and is also targeting the upcoming stable 24.4.0 version.

tomivirkki added a commit that referenced this pull request Feb 16, 2024
@tomivirkki
feat: support reverse button collapsing order in menu-bar (#7124)
8040a17
@tomivirkki tomivirkki mentioned this pull request Feb 16, 2024
Merged
tomivirkki added a commit that referenced this pull request Feb 16, 2024
@tomivirkki
feat: support reverse button collapsing order in menu-bar (#7124) (#7132
ec45e67 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

@DiegoCardoso DiegoCardoso DiegoCardoso approved these changes

@ugur-vaadin ugur-vaadin Awaiting requested review from ugur-vaadin

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.4.0 Released with Vaadin 24.4.0.alpha4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomivirkki @vaadin-bot @DiegoCardoso @sissbruecker