-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add scrollToStart and scrollToEnd API for text-area #7144
Merged
vursen
merged 8 commits into
vaadin:main
from
AbdullahGheith:feat/text-area-scrollability
Feb 28, 2024
Merged
feat: add scrollToStart and scrollToEnd API for text-area #7144
vursen
merged 8 commits into
vaadin:main
from
AbdullahGheith:feat/text-area-scrollability
Feb 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
vursen
changed the title
Feat/text area scrollability
feat: add scrollToTop and scrollToBottom APIs to text-area
Feb 27, 2024
vursen
changed the title
feat: add scrollToTop and scrollToBottom APIs to text-area
feat: add API for scrolling text-area to the start and end
Feb 27, 2024
vursen
changed the title
feat: add API for scrolling text-area to the start and end
feat: add scrollToStart and scrollToEnd API for text-area
Feb 27, 2024
FYI: Snippet to test the feature: <script type="module">
import '@vaadin/text-area';
const textarea = document.querySelector('vaadin-text-area');
const scrollToTop = document.querySelector('.scrollToTop');
scrollToTop.addEventListener('click', () => {
textarea.scrollToStart();
});
const scrollToBottom = document.querySelector('.scrollToBottom');
scrollToBottom.addEventListener('click', () => {
textarea.scrollToEnd();
});
</script>
<button class="scrollToTop">Scroll to top</button>
<button class="scrollToBottom">Scroll to bottom</button>
<vaadin-text-area label="Feedback" style="max-height: 150px"></vaadin-text-area> |
vursen
approved these changes
Feb 27, 2024
Quality Gate passedIssues Measures |
This ticket/PR has been released with Vaadin 24.4.0.alpha9 and is also targeting the upcoming stable 24.4.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces
scrollToStart
andscrollToEnd
methods for the text-area component.Followed by:
Fixes vaadin/flow-components#6042
Type of change
Checklist
Additional for
Feature
type of change