fix: set date-time-picker showWeekNumbers to false by default

[web-padawan]

Description

Fixes #7153

Note, the original property definition without default value comes from vaadin/vaadin-date-time-picker#18 which was probably just an oversight (especially as that PR didn't contain i18n implementation).

The fix works because it passes a non-undefined value to this function:

web-components/packages/date-picker/src/vaadin-month-calendar-mixin.js

Lines 193 to 196 in 08f04ee

	_getWeekDayNames(i18n, showWeekNumbers) {
	if (i18n === undefined || showWeekNumbers === undefined) {
	return [];
	}

Which is then used to render short day names in the month calendar:

web-components/packages/date-picker/src/vaadin-month-calendar.js

Lines 37 to 41 in 08f04ee

	<template is="dom-repeat" items="[[_getWeekDayNames(i18n, showWeekNumbers)]]">
	<th role="columnheader" part="weekday" scope="col" abbr$="[[item.weekDay]]" aria-hidden="true">
	[[item.weekDayShort]]
	</th>
	</template>

Type of change

• Bugfix

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

[vaadin-bot]

This ticket/PR has been released with Vaadin 24.4.0.alpha9 and is also targeting the upcoming stable 24.4.0 version.