Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expand parent items when item is set current #7183

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

ugur-vaadin
Copy link
Contributor

Description

This PR expands the parent side nav items when an item is set current. The expanding is done recursively, starting from the root level.

Fixes #7182

Type of change

  • Bugfix
  • Feature

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.
  • Enhancement / new feature was discussed in a corresponding GitHub issue and Acceptance Criteria were created.

Copy link

sonarcloud bot commented Mar 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ugur-vaadin ugur-vaadin requested a review from vursen March 8, 2024 11:56
@sissbruecker sissbruecker self-requested a review March 11, 2024 11:01
@ugur-vaadin ugur-vaadin removed the request for review from vursen March 11, 2024 11:48
@ugur-vaadin ugur-vaadin merged commit 736e3ab into main Mar 11, 2024
9 checks passed
@ugur-vaadin ugur-vaadin deleted the feat-expand-parent-items-when-item-is-set-current branch March 11, 2024 11:48
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.4.0.alpha15 and is also targeting the upcoming stable 24.4.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatically Expand the Parent NavItem of the highlighted child NavItem
3 participants