fix: reset tabindex to -1 when initializing menu item #7203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Mar 13, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Mar 14, 2024
web-padawan
added a commit
that referenced
this pull request
Mar 14, 2024
web-padawan
added a commit
that referenced
this pull request
Mar 14, 2024
web-padawan
added a commit
that referenced
this pull request
Mar 14, 2024
|
This ticket/PR has been released with Vaadin 24.4.0.alpha15 and is also targeting the upcoming stable 24.4.0 version. |
This was referenced Jun 10, 2024
Closed
[Snyk] Upgrade @vaadin/vaadin-lumo-styles from 23.4.0 to 23.5.1
vaadin/skeleton-starter-flow-cdi#663
Closed
Closed
Closed
This was referenced Jun 11, 2024
Closed
This was referenced Jun 12, 2024
[Snyk] Upgrade @vaadin/vaadin-lumo-styles from 23.4.0 to 23.5.1
vaadin/skeleton-starter-flow-cdi#665
Closed
Closed
This was referenced Jun 12, 2024
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7202
This change ensures that items on sub-menu reopening do not preserve old
tabindexattribute value. Previously, usingitem.textthe items were re-generated and list-box reset their tabindex, but withitem.componentit didn't happen.Also related to #924 which requested resetting focus in list-box specifically for
vaadin-context-menu:Type of change