Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use formatter from date picker in tests #7306

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

ugur-vaadin
Copy link
Contributor

Description

This PR updates the tests to use the formatter from date picker. The reason is that the current formatter in the test does not take time zones into consideration. This leads to tests failing when time zone is not GMT.

No related issue.

Extracted from #7293 as a follow-up to a comment.

Type of change

  • Bugfix
  • Feature
  • Test

Checklist

  • I have read the contribution guide: https://vaadin.com/docs/latest/contributing/overview
  • I have added a description following the guideline.
  • The issue is created in the corresponding repository and I have referenced it.
  • I have added tests to ensure my change is effective and works as intended.
  • New and existing tests are passing locally with my change.
  • I have performed self-review and corrected misspellings.

Copy link

sonarqubecloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan merged commit fee7bb4 into main Apr 8, 2024
9 checks passed
@web-padawan web-padawan deleted the test-use-formatter-from-date-picker-in-tests branch April 8, 2024 12:34
web-padawan pushed a commit that referenced this pull request Apr 8, 2024
…7307)

Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants