feat: add color and background selection controls to rich-text-editor #7392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/rte-color-background
branch
from
41bb388
to
6781aeb
Compare
web-padawan
force-pushed
the
feat/rte-color-background
branch
from
b831f27
to
866da7e
Compare
tomivirkki
reviewed
May 13, 2024
tomivirkki
reviewed
May 13, 2024
packages/rich-text-editor/theme/lumo/vaadin-rich-text-editor-styles.js
Outdated
Show resolved
Hide resolved
web-padawan
force-pushed
the
feat/rte-color-background
branch
from
4f6347d
to
026dad7
Compare
|
tomivirkki
approved these changes
May 13, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7134
The color selector is implemented using custom
vaadin-overlaybased component and looks like this:Type of change