Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove not needed use strict from unit tests #7393

Merged
merged 1 commit into from
May 10, 2024

Conversation

web-padawan
Copy link
Member

Description

Removed 'use strict' lines that were added when converting to Polymer 3 in vaadin/vaadin-rich-text-editor#173.
We don't need them as our tests are implemented using ES modules and therefore use strict mode automatically.

Type of change

  • Test

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@web-padawan web-padawan requested a review from vursen May 10, 2024 07:32
@web-padawan web-padawan merged commit ef304f4 into main May 10, 2024
9 checks passed
@web-padawan web-padawan deleted the test/rte-use-strict branch May 10, 2024 08:22
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants