Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement basic popover logic, move mixins from tooltip #7409

Merged
merged 16 commits into from
May 14, 2024
Merged

feat: implement basic popover logic, move mixins from tooltip #7409

merged 16 commits into from
May 14, 2024

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented May 14, 2024 •
edited
Loading

Description

Part of vaadin/platform#5271

Implemented the following logic of vaadin-popover:

  • target, for and position properties (corresponding mixins extracted from vaadin-tooltip)
  • renderer property and requestContentUpdate() method (logic copied from vaadin-dialog)
  • overlay opens on target click , closes on outside click and Esc press (default overlay behavior)

Type of change

  • Feature

This was referenced May 14, 2024
Closed
Closed
@web-padawan web-padawan force-pushed the feat/popover-initial branch 4 times, most recently from ebb853e to 0657025 Compare May 14, 2024 10:01
@web-padawan web-padawan force-pushed the feat/popover-initial branch 3 times, most recently from 300cc69 to d54da4e Compare May 14, 2024 10:58
@web-padawan web-padawan force-pushed the feat/popover-initial branch from d54da4e to d7f48c3 Compare May 14, 2024 11:07
@web-padawan web-padawan force-pushed the feat/popover-initial branch from d7f48c3 to ea13f5f Compare May 14, 2024 11:22
@web-padawan web-padawan marked this pull request as ready for review May 14, 2024 12:28
@web-padawan web-padawan requested review from tomivirkki and vursen May 14, 2024 12:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan mentioned this pull request May 14, 2024
Merged
@web-padawan web-padawan removed the request for review from vursen May 14, 2024 13:21
@web-padawan web-padawan merged commit fe73eed into main May 14, 2024
9 checks passed
@web-padawan web-padawan deleted the feat/popover-initial branch May 14, 2024 13:21
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
prerelease version for Vaadin 24.5.0 Released with Vaadin 24.5.0.alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@web-padawan @vaadin-bot @tomivirkki