Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: restore focus to the popover target on overlay close #7421

Merged
merged 1 commit into from
May 20, 2024

Conversation

web-padawan
Copy link
Member

Description

Added logic to restore focus on close to the popover target.

Type of change

  • Feature

@web-padawan web-padawan requested review from tomivirkki and vursen May 17, 2024 08:41
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@vursen vursen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested it manually and it seems to work well.

@web-padawan web-padawan removed the request for review from tomivirkki May 20, 2024 08:16
@web-padawan web-padawan merged commit dd6c5b0 into main May 20, 2024
9 checks passed
@web-padawan web-padawan deleted the feat/popover-restore-focus branch May 20, 2024 08:17
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants