-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add trigger property, make opened property public #7430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
force-pushed
the
feat/popover-trigger
branch
from
May 22, 2024 09:18
2e6d619
to
7e379c8
Compare
web-padawan
force-pushed
the
feat/popover-trigger
branch
from
May 22, 2024 09:20
7e379c8
to
cd8f324
Compare
vursen
reviewed
May 22, 2024
vursen
reviewed
May 22, 2024
vursen
approved these changes
May 22, 2024
Issue: Popover opens and immediately closes on click when modal and trigger is focus<vaadin-button id="button">Discount</vaadin-button>
<vaadin-popover for="button" position="bottom-start"></vaadin-popover>
<script type="module">
import '@vaadin/button';
import '@vaadin/horizontal-layout';
import '@vaadin/popover';
import '@vaadin/text-field';
const popover = document.querySelector('vaadin-popover');
popover.modal = true;
popover.trigger = ['focus'];
popover.renderer = (root) => {
if (root.firstChild) {
return;
}
const layout = document.createElement('vaadin-horizontal-layout');
layout.setAttribute('theme', 'spacing-s');
layout.style.alignItems = 'baseline';
const field = document.createElement('vaadin-text-field');
field.label = 'Discount code';
const button = document.createElement('vaadin-button');
button.textContent = 'Apply';
layout.append(field, button);
root.append(layout);
};
</script> |
Quality Gate passedIssues Measures |
Fixed. |
vursen
approved these changes
May 22, 2024
This ticket/PR has been released with Vaadin 24.5.0.alpha1 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
trigger
property for setting how popover opens and closes.opened
property to be public (especially formanual
trigger).Type of change