Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only close the topmost popover on esc and outside click #7480

Merged
merged 2 commits into from
Jun 10, 2024

Conversation

tomivirkki
Copy link
Member

Description

Only close the topmost popover on esc and outside click

Fixes #7466

Type of change

Bugfix

@tomivirkki tomivirkki requested review from DiegoCardoso and vursen June 7, 2024 10:05
Copy link

sonarqubecloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tomivirkki tomivirkki merged commit fcd342c into main Jun 10, 2024
9 checks passed
@tomivirkki tomivirkki deleted the fix/popover/close-nested-popovers branch June 10, 2024 12:45
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.alpha4 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[popover] Esc or outside click closes all popovers at once when they are non modal
4 participants