fix: only focus parent item if sub-menu contained focus #7519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Jul 9, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Jul 9, 2024
web-padawan
added a commit
that referenced
this pull request
Jul 9, 2024
web-padawan
added a commit
that referenced
this pull request
Jul 9, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha5 and is also targeting the upcoming stable 24.5.0 version. |
This was referenced Aug 29, 2024
Closed
Closed
Merged
Merged
Closed
Closed
This was referenced Aug 31, 2024
Closed
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#6386
Updated the context-menu to check if the sub-menu contained a focused item before closing it:
keydownfor arrow keys.I think this makes more sense than a workaround with focusing the item without showing outline.
Type of change
Note
See video below for the updated behavior:
Hover
Parent / child item is not focused when opening / closing sub-menu on hover:
context-menu-hover.mp4
Keyboard
Parent item is focused after closing a sub-menu with a focused child item:
context-menu-focus.mp4