fix: allow helper disallowed char patterns set for input (#7521) (CP: 24.3) #7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* check if event target is helper * change logic to check against input element * remove redundant checks * Add test * inline __targetIsInput * Update packages/field-base/test/input-control-mixin.test.js Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> * Update packages/field-base/test/input-control-mixin.test.js Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> * Update packages/field-base/test/input-control-mixin.test.js Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> * fix error in test * Update packages/field-base/test/input-control-mixin.test.js * chore: restore deleted newline --------- Co-authored-by: Sascha Ißbrücker <sissbruecker@vaadin.com> Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
|
web-padawan
approved these changes
Jul 10, 2024
This was referenced Aug 29, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.