fix: fix and test focus issues in vaadin upload #7643
Conversation
FrediWa
changed the title
FrediWa
requested review from
tomivirkki and
web-padawan
and removed request for
tomivirkki
| expect(document.activeElement).to.not.equal(null); | ||
| expect(document.activeElement).to.equal(uploadButton); |
There was a problem hiding this comment.
There is no need to check for null, the second check is enough.
There was a problem hiding this comment.
UPD: the previous test was incorrect due to upload-button part being removed in #4857.
So we discussed that the explicit null check might be OK to keep for now.
|
|
Hi @FrediWa and @web-padawan, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually? |
|
Hi @FrediWa and @web-padawan, when i performed cherry-pick to this commit to 24.3, i have encountered the following issue. Can you take a look and pick it manually? |
Description
Keyboard navigation in the upload list was broken. This PR fixes that by:
These choices for navigation have been discussed internally. This PR focuses on keyboard navigation, possible ARIA issues are not taken into account.
I noticed that some of the tests were false positives because
null === nullso I added to each test that compares two objects an additional check for null. Of course, as these aren't supposed to be null, I also changed the way some of the elements are query selected.Updated dev/upload.html to have proper files, this allows retrying upload for failed files.
Fixes #6292
Type of change