feat: add vaadin-dashboard-layout #7653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Aug 14, 2024
| * A mixin to enable the dashboard layout functionality | ||
| * | ||
| * @polymerMixin | ||
| * @mixes ResizeMixin |
There was a problem hiding this comment.
There is no ResizeMixin used here, so this line should be probably removed.
There was a problem hiding this comment.
Thanks, removed for now. ResizeMixin is to be added in a separate PR.
tomivirkki
force-pushed
the
feat/dashboard-layout
branch
from
0e97286 to
557352a
Compare
ugur-vaadin
reviewed
Aug 15, 2024
ugur-vaadin
approved these changes
Aug 15, 2024
Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
|
|
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the very basic layout functionality of the
<vaadin-dashboard>and<vaadin-dashboard-layout>components:--vaadin-dashboard-col-min-width: CSS variable that affects the number of column and limits how narrow the last column can shrink before it overflows--vaadin-dashboard-col-max-width: CSS variable that limits how wide the columns can grow when given enough spaceFixes https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=74624766
Type of change