fix: reset hidden state when removing panel from tabsheet #7696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a finding with React component reported internally on Slack:
The actual problem is that the web component treats any elements without
slot
attribute as panels and then doesn’t resethidden
attribute when theslot
is set (or e.g. when the element is moved to the different parent).Type of change
Note
There is an edge case with
hidden
set initially on the panel before adding it to tabsheet - it will be reset tofalse
on removing. I don't think it's a big problem