chore: use puppeteer launcher to run Chrome tests #7701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Aug 27, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha12 and is also targeting the upcoming stable 24.5.0 version. |
web-padawan
added a commit
that referenced
this pull request
Aug 29, 2024
* test: use puppeteer launcher to run Chrome tests * chore: also use Puppeteer for snapshots and integration
web-padawan
added a commit
that referenced
this pull request
Aug 29, 2024
* test: use puppeteer launcher to run Chrome tests * chore: also use Puppeteer for snapshots and integration
web-padawan
added a commit
that referenced
this pull request
Aug 29, 2024
* test: use puppeteer launcher to run Chrome tests * chore: also use Puppeteer for snapshots and integration
web-padawan
added a commit
that referenced
this pull request
Aug 29, 2024
web-padawan
added a commit
that referenced
this pull request
Aug 29, 2024
web-padawan
added a commit
that referenced
this pull request
Aug 29, 2024
web-padawan
added a commit
that referenced
this pull request
Aug 29, 2024
web-padawan
added a commit
that referenced
this pull request
Sep 19, 2024
* test: use puppeteer launcher to run Chrome tests * chore: also use Puppeteer for snapshots and integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated to use Puppeteer launcher which downloads Chromium instead of using globally installed Chrome.
Warning
Please make sure you don't have
PUPPETEER_SKIP_CHROMIUM_DOWNLOADandPUPPETEER_EXECUTABLE_PATHenv variables overridden as it might cause use an older version of Chromium instead of downloading a new one.Type of change