fix: reset overlay position target to avoid closing after items change #7702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
DiegoCardoso
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
I can confirm that this PR fixes the regression reported in vaadin/flow-components#6577
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 28, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes vaadin/flow-components#6580
Fixes vaadin/flow-components#6577
The issue is caused by the fact that I removed setting
positionTargettoundefinedin #7524 and therefore by the first time_updatePosition()is called, thepositionTargetstill contains a reference to the old menu-bar button which is no longer in the DOM. And thengetBoundingClientRect().widthfor this button is0and that closes overlay since #7454.Type of change