fix: allow focus rings on pointer coarse devices #7704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
reviewed
Aug 28, 2024
packages/date-picker/theme/lumo/vaadin-month-calendar-styles.js
Outdated
Show resolved
Hide resolved
|
web-padawan
approved these changes
Aug 29, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
* allow focus rings on pointer coarse devices * change CSS selectors * change order of selectors * fix dumb mistake
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 29, 2024
* allow focus rings on pointer coarse devices * change CSS selectors * change order of selectors * fix dumb mistake
web-padawan
pushed a commit
that referenced
this pull request
Aug 29, 2024
* allow focus rings on pointer coarse devices * change CSS selectors * change order of selectors * fix dumb mistake
web-padawan
pushed a commit
that referenced
this pull request
Aug 29, 2024
web-padawan
pushed a commit
that referenced
this pull request
Aug 29, 2024
* allow focus rings on pointer coarse devices * change CSS selectors * change order of selectors * fix dumb mistake
web-padawan
pushed a commit
that referenced
this pull request
Aug 29, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically just changes the CSS selectors that remove focus related styles on pointer: coarse to only work when the parent month-calendar does not have the focus-ring attribute. In other words, do not hide the focus ring when the user is keyboard navigating on a touch device.
Fixes #6381
Type of change