fix: do not scroll when clicking cells #7717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sissbruecker
commented
Aug 29, 2024
There was a problem hiding this comment.
Removing the __scrollIntoViewport call in scroll mixin didn't cause any test failures, so I also added some general cases where scrolling a row into view would be expected.
For clicking I also added a separate test for the details cell, since the linked issue was about clicking the details cell specifically. With the current implementation it doesn't make a difference which cell in a row you click, but can't hurt to have more test cases I guess.
web-padawan
approved these changes
Aug 30, 2024
|
DiegoCardoso
approved these changes
Aug 30, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
web-padawan
pushed a commit
that referenced
this pull request
Aug 30, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents scrolling when focusing a cell via click by:
focus({ preventScroll: true })to avoid automatic scrolling by the browserFixes #7684