fix: make resize handle not overlap with column sorter #7718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Decrease the resize handle area to use `--lumo-size-s` to avoid any overlapping with the column sorter when the column width is reduced. Also uses the resize handle width to calculate the amount of translation in the X axis to make it better center aligned. Fixes #5637
|
web-padawan
approved these changes
Aug 30, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
* fix: make resize handle not overlap with column sorter Decrease the resize handle area to use `--lumo-size-s` to avoid any overlapping with the column sorter when the column width is reduced. Also uses the resize handle width to calculate the amount of translation in the X axis to make it better center aligned. Fixes #5637
DiegoCardoso
added a commit
that referenced
this pull request
Aug 30, 2024
…4.4) (#7720) * fix: make resize handle not overlap with column sorter Decrease the resize handle area to use `--lumo-size-s` to avoid any overlapping with the column sorter when the column width is reduced. Also uses the resize handle width to calculate the amount of translation in the X axis to make it better center aligned. Fixes #5637 Co-authored-by: Diego Cardoso <diego@vaadin.com>
|
This ticket/PR has been released with Vaadin 24.5.0.alpha13 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Decrease the resize handle area to use
--lumo-size-sto avoid overlapping with the column sorter when the column width is reduced. It also uses the resize handle width to calculate the amount of translation in the X-axis to make it better center-aligned.Before
After
To test it locally, the
grid.htmlfile can be modified to add/change the columns to something like:2Then, shrink one of the columns so it starts truncating the header title and see if the sorter can be hovered/clicked as expected.
Fixes #5637
Type of change