fix: only show tooltip if the target cell is fully visible #7749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
reviewed
Sep 3, 2024
tomivirkki
reviewed
Sep 4, 2024
|
tomivirkki
approved these changes
Sep 4, 2024
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
web-padawan
added a commit
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #7744
In grids with many columns it's quite common to have cases where certain cell is not fully in the viewport due to horizontal scrolling. IMO we shouldn't show cell tooltip in this case as it might be positioned incorrectly.
Note: there is still a chance that the
vaadin-tooltipusingbottomortopposition will not be fully visible as there is a more general issue: #7744 (comment). IMO that's worth extracting to the separate ticket as it needs more thinking.Type of change