Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add assertive property to notification #7758

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #5768

Added assertive property to customize aria-live attribute of the notification card.

Type of change

  • Feature

Copy link

sonarqubecloud bot commented Sep 4, 2024

Copy link
Contributor

@sissbruecker sissbruecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Voiceover, seems to do what it should.

@web-padawan web-padawan merged commit 547f371 into main Sep 18, 2024
9 checks passed
@web-padawan web-padawan deleted the feat/notification-assertive branch September 18, 2024 09:52
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Certain types of notifications should be aria-live=assertive
3 participants