fix: use correct focused readonly checkbox group label styles #7776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Sep 10, 2024
| @@ -35,7 +35,7 @@ const checkboxGroup = css` | |||
| -webkit-text-fill-color: var(--lumo-disabled-text-color); | |||
| } | |||
|
|
|||
| :host([focused]:not([disabled])) [part='label'] { | |||
There was a problem hiding this comment.
To be sure, this style was not applied anyway because there is no way to focus a disabled checkbox group?
There was a problem hiding this comment.
Yes, exactly. I think adding it to the selector was a mistake.
vaadin-bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
web-padawan
added a commit
that referenced
this pull request
Sep 10, 2024
|
This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes a minor issue in
vaadin-checkbox-grouptheme which is currently not aligned with Lumo for other fields:web-components/packages/vaadin-lumo-styles/mixins/required-field.js
Lines 35 to 37 in d665940
web-components/packages/radio-group/theme/lumo/vaadin-radio-group-styles.js
Lines 38 to 40 in d665940
Related styles were initially introduced in vaadin/vaadin-checkbox#149 - back then, there was no
readonystate invaadin-checkbox-groupand I missed to update them later when adding it for24.4.This is how the
readonlyfocused checkbox-group label looks now, compared to readonly focused radio-group:Note: this is specific to Lumo, as we don't have corresponding styles in Material theme.
Type of change