Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filter out undefined instances when redrawing all charts #7779

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

web-padawan
Copy link
Member

Description

Part of vaadin/flow-components#6607

This fixes the first part of the issue (reference error when redrawing all charts instances) by checking for undefined.

Type of change

  • Bugfix

Copy link

sonarqubecloud bot commented Sep 9, 2024

@web-padawan web-padawan merged commit 3e14d27 into main Sep 10, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/chart-redraw-throw branch September 10, 2024 08:37
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 3e14d27
error: could not apply 3e14d27... fix: filter out undefined instances when redrawing all charts (#7779)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.5.0.beta2 and is also targeting the upcoming stable 24.5.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants