-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: drag-resizing of dashboard items #7791
feat: drag-resizing of dashboard items #7791
Conversation
adee4b4
to
8c5db8d
Compare
Note that there's no design yet for how the widgets are going to look like eventually (where the buttons are, Lumo/Material...) so I haven't invested much on perfecting the layout either. This PR is mainly about the resizing functionality. I added a min-height to the content for now, but we'll need to discuss that also once the designs are available. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added one comment for a typo.
Co-authored-by: Ugur Saglam <106508695+ugur-vaadin@users.noreply.github.com>
Quality Gate passedIssues Measures |
} | ||
} | ||
|
||
cleanup() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: could use hostConnected, hostDisconnected instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's a good tip. Pushed a refactor to use hostDisconnected
to clean up the listener
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Description
Add support for drag resizing of
<vaadin-dashboard>
widgetsKapture.2024-09-11.at.12.39.20.mp4
Added API:
dashboard-item-resize-start
: Fired when item resizing startsevent.item
: The item being resizeddashboard-item-resize-end
: Fired when item resizing endsevent.item
: The item being resizeddashboard-item-drag-resize
: Fired when an item will be resized by draggingevent.item
: The item being resizedcolspan
: The colspan to be assigned to the itemrowspan
: The rowspan to be assigned to the itemFixes https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=74626094
Part of vaadin/platform#6626
Type of change
Feature