feat: dashboard keyboard interactions #7811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
feat/keyboard-interactions
branch
from
04cfc9c
to
be2f084
Compare
tomivirkki
force-pushed
the
feat/dashboard
branch
from
30ed206
to
528e967
Compare
tomivirkki
force-pushed
the
feat/keyboard-interactions
branch
from
9445c01
to
0451a5d
Compare
tomivirkki
force-pushed
the
feat/keyboard-interactions
branch
from
e3fe73c
to
f0e8234
Compare
yuriy-fix
requested changes
Sep 18, 2024
There was a problem hiding this comment.
There is an issue in Safari (Version 17.6): the focus gets lost when trying to Tab to the next widget or after removing one of the widgets.
Steps to reproduce:
- Select the first widget with a click.
- Press Esc.
- Press Tab.
Expected behavior: The next widget is focused.
Actual behavior: The focus is lost.
|
I can't reproduce it, running the same Safari version: Kapture.2024-09-18.at.16.31.40.mp4 |
yuriy-fix
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dashboard keyboard interactions as described here.
Widget/section move-mode and resize-mode are excluded from this PR and will be added separately.
Part of https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=79678587
Type of change
Feature