docs!: deprecate internal-tab event and remove it from JSDoc #7889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-padawan
changed the title
|
vursen
approved these changes
Sep 30, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
internal-tabevent was originally designed to be used byvaadin-date-time-picker(which no longer depends onvaadin-custom-fieldsince V22) and insidevaadin-grid-pro(this was removed in #7870).Marked this event tab as deprecated and removed
@firesannotations to avoid code completion in VSCode Lit plugin.Note, there is no
@eventannotation for it which means this event is not exposed in API docs / React wrappers.Type of change