Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump Quill to fix error thrown on deleting text #7899

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #7898

Updated Quill build to include the fix from vaadin/quill#6

Type of change

  • Bugfix

Copy link

sonarqubecloud bot commented Oct 1, 2024

@web-padawan web-padawan merged commit d683e98 into main Oct 1, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/bump-quill-delta-fix branch October 1, 2024 13:46
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick d683e98
error: could not apply d683e98... fix: bump Quill to fix error thrown on deleting text (#7899)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Oct 1, 2024
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@web-padawan
Copy link
Member Author

The original PR #7613 wasn't ported to 24.4 branch (it was considered a "feature") so no need to cherry-pick there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[rich-text-editor] Error thrown when selecting and removing multi-line text
3 participants