Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing export for SelectListBox element class #7925

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

web-padawan
Copy link
Member

Description

When changing vaadin-select-list-box to not extend vaadin-list-box I added the export to the .d.ts file.
However, the corresponding JS class isn't exported, unlike SelectItem and e.g. ContextMenuListBox.

Added the export to make importing the component possible and align with other similar components.

Type of change

  • Bugfix

@web-padawan web-padawan requested a review from vursen October 2, 2024 13:36
@web-padawan web-padawan changed the title fix: add missing export for SelectListBox internal class fix: add missing export for SelectListBox element class Oct 2, 2024
@vursen
Copy link
Contributor

vursen commented Oct 3, 2024

Am I right in my assumption that this export exists because it's a slotted component? Because then vaadin-select-value-button should also be exported.

@web-padawan web-padawan force-pushed the fix/export-select-list-box branch from ad95df0 to ec3316f Compare October 3, 2024 07:36
Copy link

sonarqubecloud bot commented Oct 3, 2024

@web-padawan
Copy link
Member Author

Am I right in my assumption that this export exists because it's a slotted component?

I think it's mainly because users can create vaadin-select-list-box manually when using renderer function / directive.
At the same time, vaadin-select-value-button and vaadin-select-overlay are not supposed to be used this way.

@web-padawan web-padawan merged commit 7c917d8 into main Oct 3, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/export-select-list-box branch October 3, 2024 09:31
web-padawan added a commit that referenced this pull request Oct 3, 2024
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Oct 3, 2024
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants