fix!: only set top and left properties on drag #7970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sissbruecker
approved these changes
Oct 14, 2024
|
This ticket/PR has been released with Vaadin 24.6.0.beta1 and is also targeting the upcoming stable 24.6.0 version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the behavior of which properties the
DialogDraggableMixinsets on drag. Before, the_startDraglistener would set the initial bounds using thetop,left,width, andheightvalues, which could cause some unexpected behaviors as described in #436. With this change, only thetopandleftproperties are set when the user drags the Dialog overlay.Warning
Marking it as a breaking change, as this could potentially create some unexpected behaviors, especially if the developer defines a size for the
<vaadin-dialog-overlay>component as can be seen in more details on this comment.Part of #1060
Fix #436
Type of change