Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify focus logic in Tab keydown handler #7989

Merged
merged 3 commits into from
Oct 23, 2024
Merged

refactor: simplify focus logic in Tab keydown handler #7989

merged 3 commits into from
Oct 23, 2024

Conversation

vursen
Copy link
Contributor

@vursen vursen commented Oct 17, 2024 •
edited
Loading

Description

Refactor of the _onTabKeyDown handler in KeyboardNavigationMixin.

Summary:

  • Removed unnecessary conditional branches
  • Explained why preventDefault isn't called when the next element is this.$.table or this.$.focusexit

Type of change

  • Refactor

@vursen vursen changed the title refactor: simplify code in Tab key handler refactor: simplify focus logic in Tab keydown handler Oct 17, 2024
@vursen vursen marked this pull request as ready for review October 17, 2024 14:18
@vursen vursen force-pushed the simplify-logic-in-tab-key-down-handler branch from ed9e877 to 4c3612d Compare October 18, 2024 07:30
@vursen vursen force-pushed the simplify-logic-in-tab-key-down-handler branch from 0436d42 to 1d370b8 Compare October 19, 2024 12:38
@vursen vursen force-pushed the simplify-logic-in-tab-key-down-handler branch from 1d370b8 to c9af689 Compare October 23, 2024 10:20
@vursen vursen removed the request for review from web-padawan October 23, 2024 10:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@vursen vursen merged commit c318c01 into main Oct 23, 2024
9 checks passed
@vursen vursen deleted the simplify-logic-in-tab-key-down-handler branch October 23, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sissbruecker sissbruecker sissbruecker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vursen @sissbruecker