Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reset charts series objects when chart is detached #8115

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: reset charts series objects when chart is detached #8115

merged 1 commit into from
Nov 8, 2024

Conversation

web-padawan
Copy link
Member

Description

Fixes #8114

Type of change

  • Bugfix

tomivirkki
tomivirkki reviewed Nov 8, 2024
View reviewed changes
packages/charts/src/vaadin-chart.js Outdated Show resolved Hide resolved
packages/charts/src/vaadin-chart.js Outdated Show resolved Hide resolved
@web-padawan web-padawan mentioned this pull request Nov 8, 2024
Merged
@web-padawan web-padawan force-pushed the fix/charts-detach-series-reset branch from b494600 to d372b48 Compare November 8, 2024 12:56
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@web-padawan web-padawan removed the request for review from DiegoCardoso November 8, 2024 13:22
@web-padawan web-padawan merged commit 14f17b1 into main Nov 8, 2024
9 checks passed
@web-padawan web-padawan deleted the fix/charts-detach-series-reset branch November 8, 2024 14:12
vaadin-bot pushed a commit that referenced this pull request Nov 8, 2024
@web-padawan @vaadin-bot
fix: reset charts series objects when chart is detached (#8115)
8d63860
vaadin-bot pushed a commit that referenced this pull request Nov 8, 2024
@web-padawan @vaadin-bot
fix: reset charts series objects when chart is detached (#8115)
080656c
@vaadin-bot
Copy link
Collaborator

Hi @web-padawan and @web-padawan, when i performed cherry-pick to this commit to 24.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 14f17b1
error: could not apply 14f17b1... fix: reset charts series objects when chart is detached (#8115)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

web-padawan added a commit that referenced this pull request Nov 8, 2024
@vaadin-bot @web-padawan
fix: reset charts series objects when chart is detached (#8115) (#8122)
4851344 
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Nov 8, 2024
@vaadin-bot @web-padawan
fix: reset charts series objects when chart is detached (#8115) (#8122)
4f4ef88 
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@web-padawan web-padawan mentioned this pull request Nov 8, 2024
Merged
web-padawan added a commit that referenced this pull request Nov 8, 2024
@vaadin-bot @web-padawan
fix: reset charts series objects when chart is detached (#8115) (#8122)
d8afbc6 
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
web-padawan added a commit that referenced this pull request Nov 8, 2024
@web-padawan @vaadin-bot
fix: reset charts series objects when chart is detached (#8115) (#8124)
bfb6432 
Co-authored-by: Vaadin Bot <vaadin-bot@users.noreply.github.com>
web-padawan added a commit that referenced this pull request Nov 8, 2024
@vaadin-bot @web-padawan
fix: reset charts series objects when chart is detached (#8115) (#8123)
b337683 
Co-authored-by: Serhii Kulykov <iamkulykov@gmail.com>
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 24.6.0.alpha3 and is also targeting the upcoming stable 24.6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomivirkki tomivirkki tomivirkki approved these changes

Assignees
No one assigned
Labels
cherry-picked-23.5 cherry-picked-24.5 need to pick manually 24.4 prerelease version for Vaadin 24.6.0 Released with Vaadin 24.6.0.alpha3 target/23.5 target/24.4 target/24.5
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Updating series of a detached chart throws
3 participants
@web-padawan @vaadin-bot @tomivirkki