fix: do not render hidden combo box items #8181
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since adding the data provider controller to combo box in #7044, the component now calls
ComboBoxMixin.requestContentUpdate
when filtering using a data provider. That method iterates over every item in the overlay, regardless whether visible or hidden, and runs its renderer function:web-components/packages/combo-box/src/vaadin-combo-box-mixin.js
Lines 412 to 414 in d877284
That can lead to an issue in the Flow component when using component renderers:
This change fixes the issue by not running the renderer function for hidden items.
Fixes vaadin/flow-components#6810